Bug 187161 - Don't force black text when TextIndicator draws backgrounds or all content
Summary: Don't force black text when TextIndicator draws backgrounds or all content
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-28 15:52 PDT by Timothy Hatcher
Modified: 2018-06-28 16:23 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.02 KB, patch)
2018-06-28 15:53 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2018-06-28 15:52:05 PDT 
This can lead to bad results in dark mode.
Comment 1 Timothy Hatcher 2018-06-28 15:52:13 PDT 
<rdar://problem/40434644>
Comment 2 Timothy Hatcher 2018-06-28 15:53:43 PDT 
Created attachment 343867 [details]
Patch
Comment 3 Tim Horton 2018-06-28 15:57:38 PDT 
(In reply to Timothy Hatcher from comment #0)
> This can lead to bad results in dark mode.

I bet it can lead to bad results in any mode :P white-text-on-dark-background in normal web content would be a problem, no?
Comment 4 WebKit Commit Bot 2018-06-28 16:23:39 PDT 
Comment on attachment 343867 [details]
Patch

Clearing flags on attachment: 343867

Committed r233338: <https://trac.webkit.org/changeset/233338>
Comment 5 WebKit Commit Bot 2018-06-28 16:23:40 PDT 
All reviewed patches have been landed.  Closing bug.