Bug 187061 - EWS should pass --status-host-uses-http when invoking webkit-patch, if needed
Summary: EWS should pass --status-host-uses-http when invoking webkit-patch, if needed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-26 12:58 PDT by Daniel Bates
Modified: 2018-06-27 09:41 PDT (History)
9 users (show)

See Also:

Attachments
Patch (2.64 KB, patch)
2018-06-26 13:06 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2018-06-26 12:58:54 PDT 
EWS should pass --status-host-uses-http if needed when invoking webkit-patch.
Comment 1 Daniel Bates 2018-06-26 13:06:56 PDT 
Created attachment 343631 [details]
Patch
Comment 2 Per Arne Vollan 2018-06-26 13:54:43 PDT 
Comment on attachment 343631 [details]
Patch

R=me.
Comment 3 Daniel Bates 2018-06-26 14:13:41 PDT 
Comment on attachment 343631 [details]
Patch

Clearing flags on attachment: 343631

Committed r233220: <https://trac.webkit.org/changeset/233220>
Comment 4 Daniel Bates 2018-06-26 14:13:43 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-06-26 14:14:36 PDT 
<rdar://problem/41490138>
Comment 6 Aakash Jain 2018-06-27 09:21:05 PDT 
Was this change tested? 
It seems to break all the EWS bots <rdar://problem/41526934>.
Comment 7 Aakash Jain 2018-06-27 09:41:09 PDT 
EWS bots seems to be broken due to another configuration change (for security EWS: <rdar://problem/41497122>).