Bug 187049 - [GStreamer] Do not forget to set stream on track switching
Summary: [GStreamer] Do not forget to set stream on track switching
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-26 08:56 PDT by Thibault Saunier
Modified: 2018-06-26 10:01 PDT (History)
4 users (show)

See Also:

Attachments
[GStreamer] Do not forget to set stream on track switching (2.11 KB, patch)
2018-06-26 08:58 PDT, Thibault Saunier 		pnormand: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
[GStreamer] Do not forget to set stream on track switching (2.15 KB, patch)
2018-06-26 09:12 PDT, Thibault Saunier 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thibault Saunier 2018-06-26 08:56:53 PDT 
Regression from Bug #186678
Comment 1 Thibault Saunier 2018-06-26 08:58:56 PDT 
Created attachment 343606 [details]
[GStreamer] Do not forget to set stream on track switching

This was an overlooked issue introduced in 186678
Comment 2 WebKit Commit Bot 2018-06-26 09:07:13 PDT 
Comment on attachment 343606 [details]
[GStreamer] Do not forget to set stream on track switching

Rejecting attachment 343606 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 343606, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: https://webkit-queues.webkit.org/results/8347645
Comment 3 Thibault Saunier 2018-06-26 09:12:36 PDT 
Created attachment 343608 [details]
[GStreamer] Do not forget to set stream on track switching

This was an overlooked issue introduced in 186678
Comment 4 WebKit Commit Bot 2018-06-26 09:59:04 PDT 
Comment on attachment 343608 [details]
[GStreamer] Do not forget to set stream on track switching

Clearing flags on attachment: 343608

Committed r233202: <https://trac.webkit.org/changeset/233202>
Comment 5 WebKit Commit Bot 2018-06-26 09:59:06 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-06-26 10:01:23 PDT 
<rdar://problem/41476703>