Bug 186869 - flattenDictionaryStruture needs to zero inline storage.
Summary: flattenDictionaryStruture needs to zero inline storage.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-20 17:23 PDT by Keith Miller
Modified: 2018-06-21 11:45 PDT (History)
5 users (show)

See Also:


Attachments
Patch (6.54 KB, patch)
2018-06-20 17:34 PDT, Keith Miller
sbarati: review+
ews: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2018-06-20 17:23:31 PDT
flattenDictionaryStruture needs to zero inline storage.
Comment 1 Keith Miller 2018-06-20 17:34:03 PDT
Created attachment 343194 [details]
Patch
Comment 2 Saam Barati 2018-06-20 17:42:14 PDT
Comment on attachment 343194 [details]
Patch

r=me
Comment 3 Build Bot 2018-06-20 19:00:07 PDT
Comment on attachment 343194 [details]
Patch

Attachment 343194 [details] did not pass jsc-ews (mac):
Output: https://webkit-queues.webkit.org/results/8271362

New failing tests:
stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-eager-no-cjit
Comment 4 Keith Miller 2018-06-21 11:41:44 PDT
(In reply to Build Bot from comment #3)
> Comment on attachment 343194 [details]
> Patch
> 
> Attachment 343194 [details] did not pass jsc-ews (mac):
> Output: https://webkit-queues.webkit.org/results/8271362
> 
> New failing tests:
> stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-eager-no-
> cjit

I think this test was flaky beforehand.
Comment 5 Keith Miller 2018-06-21 11:44:08 PDT
Committed r233048: <https://trac.webkit.org/changeset/233048>
Comment 6 Radar WebKit Bug Importer 2018-06-21 11:45:27 PDT
<rdar://problem/41337578>