Bug 186718 - Better pack ResourceResponse
Summary: Better pack ResourceResponse
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-15 19:29 PDT by Chris Dumez
Modified: 2018-06-16 12:19 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.58 KB, patch)
2018-06-15 19:31 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (3.66 KB, patch)
2018-06-15 19:38 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (3.82 KB, patch)
2018-06-16 11:30 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-06-15 19:29:58 PDT 
Better pack ResourceResponse to save some memory.
Comment 1 Chris Dumez 2018-06-15 19:31:49 PDT 
Created attachment 342869 [details]
Patch
Comment 2 Chris Dumez 2018-06-15 19:38:50 PDT 
Created attachment 342870 [details]
Patch
Comment 3 Simon Fraser (smfr) 2018-06-15 21:57:01 PDT 
Comment on attachment 342870 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342870&action=review

> Source/WebCore/platform/network/ResourceResponseBase.h:235
> +    int m_httpStatusCode;
> +    bool m_isNull;

might as well add initializers.
Comment 4 Chris Dumez 2018-06-16 11:30:33 PDT 
Created attachment 342884 [details]
Patch
Comment 5 WebKit Commit Bot 2018-06-16 12:18:49 PDT 
Comment on attachment 342884 [details]
Patch

Clearing flags on attachment: 342884

Committed r232910: <https://trac.webkit.org/changeset/232910>
Comment 6 WebKit Commit Bot 2018-06-16 12:18:51 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-06-16 12:19:23 PDT 
<rdar://problem/41189077>