Bug 186407 - Add base class to get WeakPtrFactory member and avoid some boilerplate code
Summary: Add base class to get WeakPtrFactory member and avoid some boilerplate code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-07 13:49 PDT by Chris Dumez
Modified: 2018-06-07 21:55 PDT (History)
7 users (show)

See Also:

Attachments
Patch (210.08 KB, patch)
2018-06-07 16:13 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (210.65 KB, patch)
2018-06-07 16:28 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-06-07 13:49:33 PDT 
Add base class to get WeakPtrFactory member and avoid some boilerplate code.
Comment 1 Chris Dumez 2018-06-07 16:13:21 PDT 
Created attachment 342216 [details]
Patch
Comment 2 Chris Dumez 2018-06-07 16:28:13 PDT 
Created attachment 342219 [details]
Patch
Comment 3 Brent Fulgham 2018-06-07 20:28:20 PDT 
Comment on attachment 342219 [details]
Patch

Nice cleanup!
Comment 4 WebKit Commit Bot 2018-06-07 20:56:12 PDT 
Comment on attachment 342219 [details]
Patch

Clearing flags on attachment: 342219

Committed r232613: <https://trac.webkit.org/changeset/232613>
Comment 5 WebKit Commit Bot 2018-06-07 20:56:14 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-06-07 20:57:23 PDT 
<rdar://problem/40922716>
Comment 7 Fujii Hironori 2018-06-07 21:55:27 PDT 
Committed r232615: <https://trac.webkit.org/changeset/232615>