RESOLVED FIXED 186036
[LFC] Add formatting context testing codepath in FrameViewLayoutContext 
https://bugs.webkit.org/show_bug.cgi?id=186036
Summary [LFC] Add formatting context testing codepath in FrameViewLayoutContext
zalan
Reported 2018-05-28 09:30:48 PDT
This is to verify the formatting context layout correctness.
Attachments
Patch (5.82 KB, patch)
2018-05-28 09:34 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (5.78 KB, patch)
2018-05-28 10:18 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2018-05-28 09:34:34 PDT
Created attachment 341455 [details] Patch
Antti Koivisto
Comment 2 2018-05-28 10:03:13 PDT
Comment on attachment 341455 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341455&action=review > Source/WebCore/page/FrameViewLayoutContext.cpp:39 > #include "InspectorInstrumentation.h" > +#if ENABLE(LAYOUT_FORMATTING_CONTEXT) > +#include "LayoutContainer.h" > +#include "LayoutContext.h" > +#include "LayoutTreeBuilder.h" > +#endif > #include "LayoutDisallowedScope.h" I think #if includes usually go to a separate section rather than being in the middle of the normal ones.
zalan
Comment 3 2018-05-28 10:18:45 PDT
Created attachment 341458 [details] Patch
WebKit Commit Bot
Comment 4 2018-05-28 11:56:39 PDT
Comment on attachment 341458 [details] Patch Clearing flags on attachment: 341458 Committed r232249: <https://trac.webkit.org/changeset/232249>
WebKit Commit Bot
Comment 5 2018-05-28 11:56:41 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-05-28 11:57:19 PDT
<rdar://problem/40601127>
Note You need to log in before you can comment on or make changes to this bug.