Bug 185969 - [Win][MiniBrowser] Remove URL argument of MiniBrowser::init
Summary: [Win][MiniBrowser] Remove URL argument of MiniBrowser::init
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks: 185814
  Show dependency tree / graph
 
Reported: 2018-05-24 18:45 PDT by Fujii Hironori
Modified: 2018-05-27 19:25 PDT (History)
6 users (show)

See Also:

Attachments
Patch (5.80 KB, patch)
2018-05-24 18:52 PDT, Fujii Hironori 		achristensen: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews204 for win-future (12.73 MB, application/zip)
2018-05-24 23:50 PDT, EWS Watchlist 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2018-05-24 18:45:46 PDT 
[Win][MiniBrowser] Remove URL argument of MiniBrowser::init

MiniBrowser::init takes URL argument, but it's used only for loading default HTML if URL is not given.

* Add a new method MiniBrowser::loadHTMLString
* Remove loadHTMLString process from MiniBrowser::prepareViews
Comment 1 Fujii Hironori 2018-05-24 18:52:22 PDT 
Created attachment 341239 [details]
Patch
Comment 2 EWS Watchlist 2018-05-24 23:50:21 PDT 
Comment on attachment 341239 [details]
Patch

Attachment 341239 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7796137

New failing tests:
http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html
Comment 3 EWS Watchlist 2018-05-24 23:50:32 PDT 
Created attachment 341255 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 4 Alex Christensen 2018-05-25 17:09:23 PDT 
Comment on attachment 341239 [details]
Patch

sure
Comment 5 Fujii Hironori 2018-05-27 19:23:13 PDT 
Committed r232230: <https://trac.webkit.org/changeset/232230>
Comment 6 Radar WebKit Bug Importer 2018-05-27 19:25:21 PDT 
<rdar://problem/40589791>