RESOLVED FIXED 185969
[Win][MiniBrowser] Remove URL argument of MiniBrowser::init 
https://bugs.webkit.org/show_bug.cgi?id=185969
Summary [Win][MiniBrowser] Remove URL argument of MiniBrowser::init
Fujii Hironori
Reported 2018-05-24 18:45:46 PDT
[Win][MiniBrowser] Remove URL argument of MiniBrowser::init MiniBrowser::init takes URL argument, but it's used only for loading default HTML if URL is not given. * Add a new method MiniBrowser::loadHTMLString * Remove loadHTMLString process from MiniBrowser::prepareViews
Attachments
Patch (5.80 KB, patch)
2018-05-24 18:52 PDT, Fujii Hironori 		achristensen: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews204 for win-future (12.73 MB, application/zip)
2018-05-24 23:50 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2018-05-24 18:52:22 PDT
Created attachment 341239 [details] Patch
EWS Watchlist
Comment 2 2018-05-24 23:50:21 PDT
Comment on attachment 341239 [details] Patch Attachment 341239 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7796137 New failing tests: http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html
EWS Watchlist
Comment 3 2018-05-24 23:50:32 PDT
Created attachment 341255 [details] Archive of layout-test-results from ews204 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Alex Christensen
Comment 4 2018-05-25 17:09:23 PDT
Comment on attachment 341239 [details] Patch sure
Fujii Hironori
Comment 5 2018-05-27 19:23:13 PDT
Committed r232230: <https://trac.webkit.org/changeset/232230>
Radar WebKit Bug Importer
Comment 6 2018-05-27 19:25:21 PDT
<rdar://problem/40589791>
Note You need to log in before you can comment on or make changes to this bug.