Bug 185884 - Rename Atomics.wake to Atomics.notify per ES standard change
Summary: Rename Atomics.wake to Atomics.notify per ES standard change
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-22 13:55 PDT by Michael Saboff
Modified: 2020-03-07 02:35 PST (History)
8 users (show)

See Also:

Attachments
Work i Progress Patch (9.03 KB, patch)
2018-07-24 12:03 PDT, Michael Saboff 		darin: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews200 for win-future (12.79 MB, application/zip)
2018-07-24 14:06 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2018-05-22 13:55:41 PDT 
Atomics.wake was changed to Atomics.notify at the May 2018 TC39 meeting.  This change should be made before we re-enable Shared Array Buffers.
Comment 1 Michael Saboff 2018-07-24 12:03:06 PDT 
Created attachment 345698 [details]
Work i Progress Patch

This change won't take affect until Shared Array Buffers are re-enabled.  This change may cause the Chakra and Test262 tests to fail depending on when they are updated.
Comment 2 EWS Watchlist 2018-07-24 14:05:56 PDT 
Comment on attachment 345698 [details]
Work i Progress Patch

Attachment 345698 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8641380

New failing tests:
http/tests/security/video-poster-cross-origin-crash2.html
Comment 3 EWS Watchlist 2018-07-24 14:06:07 PDT 
Created attachment 345713 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit