Bug 185838 - Web Automation: always return an empty cookie list if document.cookieURL() is empty
Summary: Web Automation: always return an empty cookie list if document.cookieURL() is...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brian Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-21 14:15 PDT by Brian Burg
Modified: 2018-05-21 15:10 PDT (History)
8 users (show)

See Also:


Attachments
Patch (1.96 KB, patch)
2018-05-21 14:20 PDT, Brian Burg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2018-05-21 14:15:12 PDT
YMMV if trying to fetch cookies from a null or empty URL, but it crashes on Mac.
Comment 1 Brian Burg 2018-05-21 14:15:43 PDT
<rdar://problem/37737526>
Comment 2 Brian Burg 2018-05-21 14:20:03 PDT
Created attachment 340890 [details]
Patch
Comment 3 Daniel Bates 2018-05-21 15:06:47 PDT
Comment on attachment 340890 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340890&action=review

> Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp:754
> +    if (!document.cookieURL().isEmpty())

It would good to understand how document's cookie URL can be empty given that the document has an associated frame. I haven't looked at the radar. Maybe this happens for a newly opened window?
Comment 4 WebKit Commit Bot 2018-05-21 15:10:41 PDT
Comment on attachment 340890 [details]
Patch

Clearing flags on attachment: 340890

Committed r232031: <https://trac.webkit.org/changeset/232031>
Comment 5 WebKit Commit Bot 2018-05-21 15:10:43 PDT
All reviewed patches have been landed.  Closing bug.