Bug 185815 - WebView._preferencesChanged should apply colorFilterEnabled preference before parsing user stylesheet
Summary: WebView._preferencesChanged should apply colorFilterEnabled preference before...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-21 00:37 PDT by Antti Koivisto
Modified: 2018-05-21 09:33 PDT (History)
3 users (show)

See Also:

Attachments
patch (2.20 KB, patch)
2018-05-21 00:48 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2018-05-21 00:37:25 PDT 
User stylesheet parsing may depend on colorFilterEnabled preference.
Comment 1 Antti Koivisto 2018-05-21 00:43:03 PDT 
<rdar://problem/40310069>
Comment 2 Antti Koivisto 2018-05-21 00:48:01 PDT 
Created attachment 340830 [details]
patch
Comment 3 Simon Fraser (smfr) 2018-05-21 08:44:39 PDT 
Comment on attachment 340830 [details]
patch

Would be nice to break this messy function up to be more explicit about ordering dependencies.
Comment 4 WebKit Commit Bot 2018-05-21 09:33:52 PDT 
Comment on attachment 340830 [details]
patch

Clearing flags on attachment: 340830

Committed r232016: <https://trac.webkit.org/changeset/232016>
Comment 5 WebKit Commit Bot 2018-05-21 09:33:53 PDT 
All reviewed patches have been landed.  Closing bug.