Bug 185747 - Remove unnecessary exit fullscreen call on application resume
Summary: Remove unnecessary exit fullscreen call on application resume
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-17 14:50 PDT by Jeremy Jones
Modified: 2018-05-23 09:27 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.47 KB, patch)
2018-05-17 14:54 PDT, Jeremy Jones
jer.noble: review+
Details | Formatted Diff | Diff
Patch For Landing (2.47 KB, patch)
2018-05-17 15:03 PDT, Jeremy Jones
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2018-05-17 14:50:52 PDT
Remove unnecessary exit fullscreen call on application resume
Comment 1 Jeremy Jones 2018-05-17 14:51:26 PDT
rdar://problem/40345725
Comment 2 Jeremy Jones 2018-05-17 14:54:46 PDT
Created attachment 340653 [details]
Patch
Comment 3 Jer Noble 2018-05-17 15:01:14 PDT
Comment on attachment 340653 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340653&action=review

> Source/WebCore/ChangeLog:11
> +        Auto-PiP doesn't automatically returns to fullscreen on app resume,

Nit: "doesn't returns"
Comment 4 Jeremy Jones 2018-05-17 15:03:21 PDT
Created attachment 340655 [details]
Patch For Landing
Comment 5 WebKit Commit Bot 2018-05-17 16:03:55 PDT
Comment on attachment 340655 [details]
Patch For Landing

Clearing flags on attachment: 340655

Committed r231929: <https://trac.webkit.org/changeset/231929>