Bug 185671 - StorageManager::deleteLocalStorageOriginsModifiedSince: database files get deleted before database connections close
Summary: StorageManager::deleteLocalStorageOriginsModifiedSince: database files get de...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-15 18:28 PDT by Sihui Liu
Modified: 2018-05-15 21:44 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.91 KB, patch)
2018-05-15 18:41 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2018-05-15 18:28:40 PDT 
We should always close the database before unlinking database file.
Comment 1 Sihui Liu 2018-05-15 18:41:46 PDT 
Created attachment 340461 [details]
Patch
Comment 2 Geoffrey Garen 2018-05-15 21:15:42 PDT 
Comment on attachment 340461 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2018-05-15 21:43:20 PDT 
Comment on attachment 340461 [details]
Patch

Clearing flags on attachment: 340461

Committed r231837: <https://trac.webkit.org/changeset/231837>
Comment 4 WebKit Commit Bot 2018-05-15 21:43:21 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-05-15 21:44:19 PDT 
<rdar://problem/40283939>