Bug 185355 - DFG AI doesn't need to merge valuesAtTail - it can just assign them
Summary: DFG AI doesn't need to merge valuesAtTail - it can just assign them
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-05 12:14 PDT by Filip Pizlo
Modified: 2018-05-07 17:07 PDT (History)
6 users (show)

See Also:


Attachments
the patch (2.39 KB, patch)
2018-05-05 12:17 PDT, Filip Pizlo
mark.lam: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews200 for win-future (12.79 MB, application/zip)
2018-05-05 16:47 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2018-05-05 12:14:01 PDT
Patch forthcoming.
Comment 1 Filip Pizlo 2018-05-05 12:17:53 PDT
Created attachment 339654 [details]
the patch
Comment 2 EWS Watchlist 2018-05-05 16:47:27 PDT
Comment on attachment 339654 [details]
the patch

Attachment 339654 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7579998

New failing tests:
http/tests/security/video-poster-cross-origin-crash2.html
Comment 3 EWS Watchlist 2018-05-05 16:47:38 PDT
Created attachment 339658 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 4 Mark Lam 2018-05-07 15:01:33 PDT
Comment on attachment 339654 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339654&action=review

> Source/JavaScriptCore/ChangeLog:15
> +        if it's getting the merged valuesAtTail or just some correct answer to for valuesAtTail.

typo: /to for/for/
Comment 5 Filip Pizlo 2018-05-07 17:05:29 PDT
Landed in https://trac.webkit.org/changeset/231467/webkit
Comment 6 Radar WebKit Bug Importer 2018-05-07 17:07:37 PDT
<rdar://problem/40042939>