Bug 185165 - WebKit should send fake macOS user agent to docs.google.com
Summary: WebKit should send fake macOS user agent to docs.google.com
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-01 09:00 PDT by Michael Catanzaro
Modified: 2021-02-17 07:08 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.91 KB, patch)
2018-05-01 09:05 PDT, Michael Catanzaro 		cgarcia: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2018-05-01 09:00:09 PDT 
WebKit should send fake macOS user agent to docs.google.com, to eliminate the unsupported browser warning.
Comment 1 Michael Catanzaro 2018-05-01 09:05:00 PDT 
Created attachment 339200 [details]
Patch
Comment 2 WebKit Commit Bot 2018-05-03 01:23:23 PDT 
Comment on attachment 339200 [details]
Patch

Rejecting attachment 339200 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 339200, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
/platform/UserAgentQuirks.cpp
Hunk #1 succeeded at 106 (offset 5 lines).
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp
Hunk #1 FAILED at 93.
1 out of 1 hunk FAILED -- saving rejects to file Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Carlos Garcia Campos']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/7548669
Comment 3 Michael Catanzaro 2018-05-03 10:08:29 PDT 
Committed r231311: <https://trac.webkit.org/changeset/231311>