Bug 185126 - LICM shouldn't hoist nodes if hoisted nodes exited in that code block
Summary: LICM shouldn't hoist nodes if hoisted nodes exited in that code block
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-29 18:05 PDT by Filip Pizlo
Modified: 2018-04-30 17:08 PDT (History)
6 users (show)

See Also:

Attachments
the patch (3.10 KB, patch)
2018-04-29 18:14 PDT, Filip Pizlo 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2018-04-29 18:05:00 PDT 
We allow speculative hoisting, but only once per codeBlock.
Comment 1 Filip Pizlo 2018-04-29 18:14:58 PDT 
Created attachment 339102 [details]
the patch
Comment 2 Saam Barati 2018-04-30 09:21:00 PDT 
Comment on attachment 339102 [details]
the patch

r=me
Comment 3 Filip Pizlo 2018-04-30 17:05:02 PDT 
Landed in https://trac.webkit.org/changeset/231185/webkit
Comment 4 Radar WebKit Bug Importer 2018-04-30 17:08:04 PDT 
<rdar://problem/39855250>