Bug 185024 - [LFC] Implement BlockFormattingContext::layout logic and its dependencies
Summary: [LFC] Implement BlockFormattingContext::layout logic and its dependencies
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-25 22:14 PDT by zalan
Modified: 2018-04-27 11:18 PDT (History)
7 users (show)

See Also:


Attachments
Patch (22.73 KB, patch)
2018-04-25 22:19 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (13.33 KB, patch)
2018-04-27 10:31 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (13.34 KB, patch)
2018-04-27 10:39 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-04-25 22:14:05 PDT
They are all empty functions though.
Comment 1 zalan 2018-04-25 22:19:11 PDT
Created attachment 338856 [details]
Patch
Comment 2 zalan 2018-04-25 22:21:08 PDT
Comment on attachment 338856 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338856&action=review

> Source/WebCore/ChangeLog:3
> +        [LFC] Implement BlockFormattingContext::layout logic and its dependencies

I think I'll split this patch and create (at least) 3 separate patches.
1. Floating context construction logic
2. BlockFormttingContext::layout()
3. Other, unrelated changes.
Comment 3 zalan 2018-04-26 09:51:42 PDT
bug 185031
bug 185032
Comment 4 zalan 2018-04-27 10:31:32 PDT
Created attachment 338999 [details]
Patch
Comment 5 Antti Koivisto 2018-04-27 10:36:37 PDT
Comment on attachment 338999 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338999&action=review

> Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp:69
> +        // Travers down on the descendants and compute width/static position until we find a leaf node.

Probably "traverse down"
Comment 6 zalan 2018-04-27 10:37:12 PDT
(In reply to Antti Koivisto from comment #5)
> Comment on attachment 338999 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=338999&action=review
> 
> > Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp:69
> > +        // Travers down on the descendants and compute width/static position until we find a leaf node.
> 
> Probably "traverse down"
Most probably!
Comment 7 zalan 2018-04-27 10:39:25 PDT
Created attachment 339003 [details]
Patch
Comment 8 WebKit Commit Bot 2018-04-27 11:17:52 PDT
Comment on attachment 339003 [details]
Patch

Clearing flags on attachment: 339003

Committed r231108: <https://trac.webkit.org/changeset/231108>
Comment 9 WebKit Commit Bot 2018-04-27 11:17:53 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2018-04-27 11:18:22 PDT
<rdar://problem/39797958>