They are all empty functions though.
Created attachment 338856 [details] Patch
Comment on attachment 338856 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338856&action=review > Source/WebCore/ChangeLog:3 > + [LFC] Implement BlockFormattingContext::layout logic and its dependencies I think I'll split this patch and create (at least) 3 separate patches. 1. Floating context construction logic 2. BlockFormttingContext::layout() 3. Other, unrelated changes.
bug 185031 bug 185032
Created attachment 338999 [details] Patch
Comment on attachment 338999 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338999&action=review > Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp:69 > + // Travers down on the descendants and compute width/static position until we find a leaf node. Probably "traverse down"
(In reply to Antti Koivisto from comment #5) > Comment on attachment 338999 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=338999&action=review > > > Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp:69 > > + // Travers down on the descendants and compute width/static position until we find a leaf node. > > Probably "traverse down" Most probably!
Created attachment 339003 [details] Patch
Comment on attachment 339003 [details] Patch Clearing flags on attachment: 339003 Committed r231108: <https://trac.webkit.org/changeset/231108>
All reviewed patches have been landed. Closing bug.
<rdar://problem/39797958>