RESOLVED FIXED185024
[LFC] Implement BlockFormattingContext::layout logic and its dependencies 
https://bugs.webkit.org/show_bug.cgi?id=185024
Summary [LFC] Implement BlockFormattingContext::layout logic and its dependencies
alan
Reported 2018-04-25 22:14:05 PDT
They are all empty functions though.
Attachments
Patch (22.73 KB, patch)
2018-04-25 22:19 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (13.33 KB, patch)
2018-04-27 10:31 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (13.34 KB, patch)
2018-04-27 10:39 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2018-04-25 22:19:11 PDT
Created attachment 338856 [details] Patch
alan
Comment 2 2018-04-25 22:21:08 PDT
Comment on attachment 338856 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338856&action=review > Source/WebCore/ChangeLog:3 > + [LFC] Implement BlockFormattingContext::layout logic and its dependencies I think I'll split this patch and create (at least) 3 separate patches. 1. Floating context construction logic 2. BlockFormttingContext::layout() 3. Other, unrelated changes.
alan
Comment 3 2018-04-26 09:51:42 PDT
bug 185031 bug 185032
alan
Comment 4 2018-04-27 10:31:32 PDT
Created attachment 338999 [details] Patch
Antti Koivisto
Comment 5 2018-04-27 10:36:37 PDT
Comment on attachment 338999 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338999&action=review > Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp:69 > + // Travers down on the descendants and compute width/static position until we find a leaf node. Probably "traverse down"
alan
Comment 6 2018-04-27 10:37:12 PDT
(In reply to Antti Koivisto from comment #5) > Comment on attachment 338999 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=338999&action=review > > > Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp:69 > > + // Travers down on the descendants and compute width/static position until we find a leaf node. > > Probably "traverse down" Most probably!
alan
Comment 7 2018-04-27 10:39:25 PDT
Created attachment 339003 [details] Patch
WebKit Commit Bot
Comment 8 2018-04-27 11:17:52 PDT
Comment on attachment 339003 [details] Patch Clearing flags on attachment: 339003 Committed r231108: <https://trac.webkit.org/changeset/231108>
WebKit Commit Bot
Comment 9 2018-04-27 11:17:53 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2018-04-27 11:18:22 PDT
<rdar://problem/39797958>
Note You need to log in before you can comment on or make changes to this bug.