Bug 184993 - Add lazy initialization of caption display mode for videos.
Summary: Add lazy initialization of caption display mode for videos.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-25 13:10 PDT by Per Arne Vollan
Modified: 2018-04-26 08:04 PDT (History)
8 users (show)

See Also:


Attachments
Patch (5.03 KB, patch)
2018-04-25 13:32 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2018-04-25 13:10:15 PDT
The call to MACaptionAppearanceGetDisplayType in CaptionUserPreferencesMediaAF::captionDisplayMode() is showing up in samples when called from HTMLMediaElement::finishInitialization().
Comment 1 Per Arne Vollan 2018-04-25 13:32:08 PDT
Created attachment 338781 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2018-04-25 15:23:19 PDT
<rdar://problem/39737230>
Comment 3 Per Arne Vollan 2018-04-26 07:37:50 PDT
Comment on attachment 338781 [details]
Patch

Thanks for reviewing!
Comment 4 WebKit Commit Bot 2018-04-26 08:04:22 PDT
Comment on attachment 338781 [details]
Patch

Clearing flags on attachment: 338781

Committed r231045: <https://trac.webkit.org/changeset/231045>
Comment 5 WebKit Commit Bot 2018-04-26 08:04:23 PDT
All reviewed patches have been landed.  Closing bug.