Bug 184944 – Don't activate Selection Assistant unless it is actually needed.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Megan Gardner]

Don't activate Selection Assistant unless it is actually needed.

[Megan Gardner]

Created attachment 338685 [details]
Patch

[Tim Horton]

Comment on attachment 338685 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338685&action=review

> Source/WebKit/ChangeLog:9
> +        Don't activate the selection unless we need to. Activating on init is overeager and allowing Javascript to 

JavaScript

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:-1937
> -    if (self.isFirstResponder && !self.suppressAssistantSelectionView)
> -        [_textSelectionAssistant activateSelection];

What does not having this break? :) Do you know why it was here? The fact that the tests are happy is promising, though?

> LayoutTests/ChangeLog:9
> +        Turning on previously flakey tests that a fixed with this change.

"a fixed"

[Megan Gardner]

I do not know why it was here before, but it seems to work fine without it. Much of the code around these assistants is crufty, so I expect it was needed for some reason and that reason is now either handled elsewhere or just not relevant anymore.

[Megan Gardner]

https://trac.webkit.org/changeset/231016/webkit

[Radar WebKit Bug Importer]

<rdar://problem/39732559>