Bug 184624 - Collection fragment identifiers don't use PostScript names
Summary: Collection fragment identifiers don't use PostScript names
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-13 21:11 PDT by Myles C. Maxfield
Modified: 2018-05-02 13:34 PDT (History)
8 users (show)

See Also:

Attachments
Patch (9.76 KB, patch)
2018-04-17 12:18 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (9.84 KB, patch)
2018-04-30 18:38 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (23.01 KB, patch)
2018-05-01 19:49 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (23.03 KB, patch)
2018-05-01 20:31 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (23.71 KB, patch)
2018-05-01 21:19 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2018-04-13 21:11:00 PDT 
We implemented an old version of the spec which uses integer indices instead of PostScript names.
Comment 1 Radar WebKit Bug Importer 2018-04-13 21:12:23 PDT 
<rdar://problem/39432089>
Comment 2 Myles C. Maxfield 2018-04-17 12:18:50 PDT 
Created attachment 338141 [details]
Patch
Comment 3 EWS Watchlist 2018-04-17 12:21:17 PDT 
Attachment 338141 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Myles C. Maxfield 2018-04-30 18:38:05 PDT 
Created attachment 339169 [details]
Patch
Comment 5 EWS Watchlist 2018-04-30 18:40:24 PDT 
Attachment 339169 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Myles C. Maxfield 2018-05-01 19:49:32 PDT 
Created attachment 339259 [details]
Patch
Comment 7 Myles C. Maxfield 2018-05-01 20:31:04 PDT 
Created attachment 339264 [details]
Patch
Comment 8 Myles C. Maxfield 2018-05-01 21:19:22 PDT 
Created attachment 339272 [details]
Patch
Comment 9 WebKit Commit Bot 2018-05-02 13:34:13 PDT 
Comment on attachment 339272 [details]
Patch

Clearing flags on attachment: 339272

Committed r231259: <https://trac.webkit.org/changeset/231259>
Comment 10 WebKit Commit Bot 2018-05-02 13:34:15 PDT 
All reviewed patches have been landed.  Closing bug.