Bug 184319 - REGRESSION(r222563): removed DoubleReal type check causes tons of crashes because CSE has never known how to handle SaneChain
Summary: REGRESSION(r222563): removed DoubleReal type check causes tons of crashes bec...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-04 15:18 PDT by Filip Pizlo
Modified: 2018-04-04 17:32 PDT (History)
7 users (show)

See Also:


Attachments
the patch (13.40 KB, patch)
2018-04-04 16:49 PDT, Filip Pizlo
saam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2018-04-04 15:18:30 PDT
Patch forthcoming.
Comment 1 Filip Pizlo 2018-04-04 16:49:18 PDT
Created attachment 337241 [details]
the patch
Comment 2 Filip Pizlo 2018-04-04 16:50:25 PDT
Comment on attachment 337241 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337241&action=review

> JSTests/ChangeLog:4
> +        Need a short description (OOPS!).
> +        Need the bug URL (OOPS!).

I fixed this locally
Comment 3 EWS Watchlist 2018-04-04 16:50:38 PDT
Attachment 337241 [details] did not pass style-queue:


ERROR: JSTests/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Filip Pizlo 2018-04-04 17:31:04 PDT
Landed in https://trac.webkit.org/changeset/230287/webkit
Comment 5 Radar WebKit Bug Importer 2018-04-04 17:32:24 PDT
<rdar://problem/39195119>