Bug 184314 - [Cocoa] WebDriver: test imported/w3c/webdriver/tests/cookies/add_cookie.py::test_add_non_session_cookie fails
Summary: [Cocoa] WebDriver: test imported/w3c/webdriver/tests/cookies/add_cookie.py::t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-04 13:48 PDT by BJ Burg
Modified: 2018-04-04 17:22 PDT (History)
9 users (show)

See Also:

Attachments
Patch (1.98 KB, patch)
2018-04-04 13:55 PDT, BJ Burg 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (3.92 MB, application/zip)
2018-04-04 16:15 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2018-04-04 13:48:22 PDT 
It appears that the cookie's expiry time is not round-tripping correctly, and is always off by one.
Comment 1 Radar WebKit Bug Importer 2018-04-04 13:48:45 PDT 
<rdar://problem/39186578>
Comment 2 BJ Burg 2018-04-04 13:55:40 PDT 
Created attachment 337222 [details]
Patch
Comment 3 EWS Watchlist 2018-04-04 16:15:38 PDT 
Comment on attachment 337222 [details]
Patch

Attachment 337222 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7209214

New failing tests:
accessibility/smart-invert-reference.html
Comment 4 EWS Watchlist 2018-04-04 16:15:39 PDT 
Created attachment 337238 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 5 WebKit Commit Bot 2018-04-04 17:22:14 PDT 
Comment on attachment 337222 [details]
Patch

Clearing flags on attachment: 337222

Committed r230286: <https://trac.webkit.org/changeset/230286>
Comment 6 WebKit Commit Bot 2018-04-04 17:22:16 PDT 
All reviewed patches have been landed.  Closing bug.