Bug 184204 - [macOS Sierra] Layout Test http/wpt/cache-storage/cache-put-keys.https.any.worker.html is a flaky failure
Summary: [macOS Sierra] Layout Test http/wpt/cache-storage/cache-put-keys.https.any.wo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-30 17:00 PDT by Ryan Haddad
Modified: 2018-10-01 09:18 PDT (History)
7 users (show)

See Also:

Attachments
Patch (10.87 KB, patch)
2018-09-30 14:47 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (10.94 KB, patch)
2018-09-30 15:24 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2018-03-30 17:00:47 PDT 
The following layout test is flaky on 

http/wpt/cache-storage/cache-put-keys.https.any.worker.html

Probable cause:

Unknown.

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Fwpt%2Fcache-storage%2Fcache-put-keys.https.any.worker.html

--- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/wpt/cache-storage/cache-put-keys.https.any.worker-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/wpt/cache-storage/cache-put-keys.https.any.worker-actual.txt
@@ -1,3 +1,3 @@
 
-PASS Cache.put called twice with matching Requests - keys should remain the same 
+FAIL Cache.put called twice with matching Requests - keys should remain the same assert_equals: expected 0 but got 1
Comment 1 Ryan Haddad 2018-09-19 17:17:47 PDT 
This test is still flaky. The failures appear to be limited to Sierra bots.
Comment 2 Ryan Haddad 2018-09-20 09:12:22 PDT 
Marked as flaky in https://trac.webkit.org/r236259
Comment 3 youenn fablet 2018-09-30 14:47:19 PDT 
Created attachment 351218 [details]
Patch
Comment 4 youenn fablet 2018-09-30 15:24:57 PDT 
Created attachment 351219 [details]
Patch
Comment 5 Chris Dumez 2018-10-01 08:56:03 PDT 
Comment on attachment 351219 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2018-10-01 09:17:36 PDT 
Comment on attachment 351219 [details]
Patch

Clearing flags on attachment: 351219

Committed r236662: <https://trac.webkit.org/changeset/236662>
Comment 7 WebKit Commit Bot 2018-10-01 09:17:38 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-10-01 09:18:49 PDT 
<rdar://problem/44910251>