Bug 184174 - IsoHeapImpl not IsoHeapImplBase should add itself to AllIsoHeaps
Summary: IsoHeapImpl not IsoHeapImplBase should add itself to AllIsoHeaps
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: bmalloc (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-29 22:23 PDT by Saam Barati
Modified: 2018-04-05 18:30 PDT (History)
14 users (show)

See Also:

Attachments
patch (1.88 KB, patch)
2018-04-04 12:42 PDT, Saam Barati 		fpizlo: review+
Details | Formatted Diff | Diff
patch for landing (2.25 KB, patch)
2018-04-04 12:54 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
patch for landing (2.23 KB, patch)
2018-04-05 17:00 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2018-03-29 22:23:22 PDT 
Otherwise, another thread may see a partially formed IsoHeapImpl...
Comment 1 Saam Barati 2018-04-04 12:42:50 PDT 
Created attachment 337209 [details]
patch
Comment 2 Saam Barati 2018-04-04 12:54:17 PDT 
Created attachment 337210 [details]
patch for landing
Comment 3 EWS Watchlist 2018-04-04 12:56:37 PDT 
Attachment 337210 [details] did not pass style-queue:


ERROR: Source/bmalloc/ChangeLog:7:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Saam Barati 2018-04-05 17:00:03 PDT 
Created attachment 337313 [details]
patch for landing
Comment 5 WebKit Commit Bot 2018-04-05 18:29:30 PDT 
Comment on attachment 337313 [details]
patch for landing

Clearing flags on attachment: 337313

Committed r230317: <https://trac.webkit.org/changeset/230317>
Comment 6 WebKit Commit Bot 2018-04-05 18:29:32 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-04-05 18:30:26 PDT 
<rdar://problem/39227401>