Bug 183763 - Have select multiple controls follow system appearance
Summary: Have select multiple controls follow system appearance
Status: CLOSED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-19 21:14 PDT by Megan Gardner
Modified: 2021-11-01 12:05 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.54 KB, patch)
2018-03-19 21:16 PDT, Megan Gardner 		ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews204 for win-future (4.88 MB, application/zip)
2018-03-20 00:36 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2018-03-19 21:14:33 PDT 
Have select multiple controls follow system appearance
Comment 1 Megan Gardner 2018-03-19 21:16:00 PDT 
Created attachment 336097 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2018-03-19 21:16:41 PDT 
<rdar://problem/38649724>
Comment 3 Tim Horton 2018-03-19 21:33:32 PDT 
Comment on attachment 336097 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336097&action=review

> Source/WebCore/css/html.css:365
> +    color: ButtonText;

Just because they’re case insensitive doesn’t mean you need to go flaunting it :) I think “buttontext” or maybe “buttonText” but not this.

> Source/WebCore/css/html.css:902
> +    color: ButtonText;
> +    background-color: InactiveCaption;

Ditto. Also I’m really not sure how this is going to go for the other platforms. We might have to PLATFORM(MAC) this? Do other people have colors for these?
Comment 4 EWS Watchlist 2018-03-20 00:35:59 PDT 
Comment on attachment 336097 [details]
Patch

Attachment 336097 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7035602

Number of test failures exceeded the failure limit.
Comment 5 EWS Watchlist 2018-03-20 00:36:04 PDT 
Created attachment 336108 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 6 Megan Gardner 2021-08-17 19:08:39 PDT 
Updated to use semantic colors in a later patch, this is not needed.
Comment 7 Alex Christensen 2021-11-01 12:03:06 PDT 
Comment on attachment 336097 [details]
Patch

This has been requesting review for more than one year.  If this is still needed, please rebase and re-request review.