Bug 18354 - feFlood in attribute should be removed according to SVG 1.1 Errata
Summary: feFlood in attribute should be removed according to SVG 1.1 Errata
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-07 23:43 PDT by Rob Buis
Modified: 2008-04-08 07:59 PDT (History)
1 user (show)

See Also:


Attachments
First attempt (3.04 KB, patch)
2008-04-07 23:51 PDT, Rob Buis
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Rob Buis 2008-04-07 23:51:40 PDT
Created attachment 20400 [details]
First attempt

Simple removal patch.
Cheers,

Rob.
Comment 2 Rob Buis 2008-04-08 00:23:58 PDT
Landed in r31718.
Comment 3 Chris Lord 2008-04-08 07:17:59 PDT
Since this change, WebKit no longer builds for me:

WebCore/svg/SVGFEFloodElement.cpp: In member function ‘virtual WebCore::SVGFEFlood* WebCore::SVGFEFloodElement::filterEffect(WebCore::SVGResourceFilter*) const’:
WebCore/svg/SVGFEFloodElement.cpp:57: error: ‘in1’ was not declared in this scope
Comment 4 Rob Buis 2008-04-08 07:59:41 PDT
Hi Chris,

(In reply to comment #3)
> Since this change, WebKit no longer builds for me:
> WebCore/svg/SVGFEFloodElement.cpp: In member function ‘virtual
> WebCore::SVGFEFlood*
> WebCore::SVGFEFloodElement::filterEffect(WebCore::SVGResourceFilter*) const’:
> WebCore/svg/SVGFEFloodElement.cpp:57: error: ‘in1’ was not declared in this
> scope

Oops! Wierd that I didnt see a compile error myself, or it was too late last night and didnt notice...
Just remove that line I'd say, and see if someone can commit it for you if needed. I'll only be able to correct it after work, in an hour or two/three.
Cheers,

Rob.