Bug 183454 - libwebrtc update broke internal builds
Summary: libwebrtc update broke internal builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-08 09:04 PST by youenn fablet
Modified: 2018-03-08 11:33 PST (History)
7 users (show)

See Also:

Attachments
Patch (25.08 KB, patch)
2018-03-08 09:14 PST, youenn fablet 		eric.carlson: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-03-08 09:04:10 PST 
libwebrtc update broke internal builds, probably due to a header search path
Comment 1 youenn fablet 2018-03-08 09:14:23 PST 
Created attachment 335303 [details]
Patch
Comment 2 WebKit Commit Bot 2018-03-08 11:28:51 PST 
Comment on attachment 335303 [details]
Patch

Rejecting attachment 335303 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 335303, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
fs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 229417 = 88ff7f7082c7ca645f84d60635084f131152a591
r229418 = 8cad37a6e233af9dd515d5afd0d3937800a045f8
r229419 = 3af6afb7f8e91af631266f345bd947a199cf4f42
r229420 = b9ffaa43587ded2c58d96f2f1cfc9ec12c95df9d
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/6859863
Comment 3 youenn fablet 2018-03-08 11:32:47 PST 
Committed r229421: <https://trac.webkit.org/changeset/229421>
Comment 4 Radar WebKit Bug Importer 2018-03-08 11:33:22 PST 
<rdar://problem/38270510>