Bug 183405 - checkForSiblingStyleChanges should use internal versions of the invalidation functions
Summary: checkForSiblingStyleChanges should use internal versions of the invalidation ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-07 05:20 PST by Antti Koivisto
Modified: 2018-03-07 10:28 PST (History)
4 users (show)

See Also:


Attachments
patch (6.93 KB, patch)
2018-03-07 05:28 PST, Antti Koivisto
ews: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews200 for win-future (12.09 MB, application/zip)
2018-03-07 07:06 PST, Build Bot
no flags Details
patch (8.49 KB, patch)
2018-03-07 08:28 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2018-03-07 05:20:29 PST
It already knows about sibling combinators.
Comment 1 Radar WebKit Bug Importer 2018-03-07 05:21:09 PST
<rdar://problem/38218310>
Comment 2 Antti Koivisto 2018-03-07 05:28:15 PST
Created attachment 335186 [details]
patch
Comment 3 Build Bot 2018-03-07 07:06:03 PST
Comment on attachment 335186 [details]
patch

Attachment 335186 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/6838884

New failing tests:
fast/selectors/first-child-sibling-style-update.html
fast/selectors/first-child-direct-adjacent-style-update.html
Comment 4 Build Bot 2018-03-07 07:06:14 PST
Created attachment 335191 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 Antti Koivisto 2018-03-07 08:28:25 PST
Created attachment 335193 [details]
patch
Comment 6 WebKit Commit Bot 2018-03-07 10:28:00 PST
Comment on attachment 335193 [details]
patch

Clearing flags on attachment: 335193

Committed r229368: <https://trac.webkit.org/changeset/229368>
Comment 7 WebKit Commit Bot 2018-03-07 10:28:01 PST
All reviewed patches have been landed.  Closing bug.