Bug 183175 – JSC crash with `import("")`

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[André Bargull]

SVN: rev228977
Build with: perl Tools/Scripts/build-jsc --jsc-only --debug


Executing the following test case leads to this crash:
---
1   0x7f0fd0957705 WTFCrash
2   0x48e47d WTF::VectorBufferBase<char, WTF::FastMalloc>::allocateBuffer(unsigned long)
3   0x48c170 WTF::Vector<char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>::reserveCapacity(unsigned long)
4   0x48744f WTF::Vector<char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>::expandCapacity(unsigned long)
5   0x482240 WTF::Vector<char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>::resize(unsigned long)
6   0x459f05
7   0x45a15c
8   0x45a30f GlobalObject::moduleLoaderFetch(JSC::JSGlobalObject*, JSC::ExecState*, JSC::JSModuleLoader*, JSC::JSValue, JSC::JSValue, JSC::JSValue)
9   0x7f0fd06293e9 JSC::JSModuleLoader::fetch(JSC::ExecState*, JSC::JSValue, JSC::JSValue, JSC::JSValue)
10  0x7f0fd06c027b
11  0x7f0f89eff185
---


Test case:
---
import("");
---

[Yusuke Suzuki]

Created attachment 334740 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 334740 [details]
Patch

Thanks!

[WebKit Commit Bot]

Comment on attachment 334740 [details]
Patch

Clearing flags on attachment: 334740

Committed r229092: <https://trac.webkit.org/changeset/229092>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/37985858>

[Ryan Haddad]

(In reply to WebKit Commit Bot from comment #3)
> Comment on attachment 334740 [details]
> Patch
> 
> Clearing flags on attachment: 334740
> 
> Committed r229092: <https://trac.webkit.org/changeset/229092>
The test added with this change is failing on debug JSC bots due to an unchecked exception:
https://build.webkit.org/builders/Apple%20High%20Sierra%2032-bit%20JSC%20(BuildAndTest)/builds/1298/steps/webkit-32bit-jsc-test/logs/stdio

[Yusuke Suzuki]

Committed r229129: <https://trac.webkit.org/changeset/229129>