Bug 182974 - [EME] Adopt new AVContentKeySession success delegate callback
Summary: [EME] Adopt new AVContentKeySession success delegate callback
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-20 08:31 PST by Jer Noble
Modified: 2018-02-20 10:14 PST (History)
3 users (show)

See Also:

Attachments
Patch (5.83 KB, patch)
2018-02-20 08:34 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2018-02-20 08:31:34 PST 
[EME] Adopt new AVContentKeySession success delegate callback
Comment 1 Jer Noble 2018-02-20 08:32:15 PST 
<rdar://problem/36079035>
Comment 2 Jer Noble 2018-02-20 08:34:38 PST 
Created attachment 334273 [details]
Patch
Comment 3 Eric Carlson 2018-02-20 08:49:55 PST 
Comment on attachment 334273 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334273&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:490
> +void CDMInstanceFairPlayStreamingAVFObjC::requestDidSucceed(AVContentKeyRequest *request)

Nit: you should just omit the parameter since it can never be used.
Comment 4 WebKit Commit Bot 2018-02-20 10:14:37 PST 
Comment on attachment 334273 [details]
Patch

Clearing flags on attachment: 334273

Committed r228823: <https://trac.webkit.org/changeset/228823>
Comment 5 WebKit Commit Bot 2018-02-20 10:14:38 PST 
All reviewed patches have been landed.  Closing bug.