Bug 182969 - [WinCairo] Fix compile errors in WebPageWin.cpp and WebProcessWin.cpp due to WebCore forwarding header paths
Summary: [WinCairo] Fix compile errors in WebPageWin.cpp and WebProcessWin.cpp due to ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 174003
  Show dependency treegraph
 
Reported: 2018-02-20 06:24 PST by Yousuke Kimoto
Modified: 2018-02-22 11:52 PST (History)
9 users (show)

See Also:


Attachments
Patch (2.25 KB, patch)
2018-02-20 06:28 PST, Yousuke Kimoto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuke Kimoto 2018-02-20 06:24:18 PST
WebPageWin.cpp and WebProcessWin.cpp refer header files for WebCore with an incorrect include style, which should be <WebCore/xxxx.h>.
In this ticket, styles to include the following header are fixed.
For WebPageWin.cpp:
- NotImplemented.h
- WindowsKeyboardCodes.h
For WebProcessWin.cpp:
- SharedBuffer.h
Comment 1 Yousuke Kimoto 2018-02-20 06:28:17 PST
Created attachment 334265 [details]
Patch
Comment 2 WebKit Commit Bot 2018-02-20 12:13:14 PST
Comment on attachment 334265 [details]
Patch

Rejecting attachment 334265 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 334265, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
rdparty/autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain
    result = func(*args)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open
    return self.do_open(conn_factory, req)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open
    raise URLError(err)
urllib2.URLError: <urlopen error [Errno 60] Operation timed out>

Full output: http://webkit-queues.webkit.org/results/6593997
Comment 3 WebKit Commit Bot 2018-02-22 11:51:02 PST
Comment on attachment 334265 [details]
Patch

Clearing flags on attachment: 334265

Committed r228929: <https://trac.webkit.org/changeset/228929>
Comment 4 WebKit Commit Bot 2018-02-22 11:51:03 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-02-22 11:52:24 PST
<rdar://problem/37796359>