Bug 182919 - Increase text autosizing constants for extra zoom mode
Summary: Increase text autosizing constants for extra zoom mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-18 22:26 PST by Tim Horton
Modified: 2018-02-19 10:47 PST (History)
5 users (show)

See Also:

Attachments
Patch (7.55 KB, patch)
2018-02-18 22:26 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (7.67 KB, patch)
2018-02-19 10:10 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2018-02-18 22:26:24 PST 
Increase text autosizing constants for extra zoom mode
Comment 1 Tim Horton 2018-02-18 22:26:47 PST 
Created attachment 334137 [details]
Patch
Comment 2 Wenson Hsieh 2018-02-19 00:25:38 PST 
Comment on attachment 334137 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334137&action=review

> Source/WebCore/page/Settings.yaml:724
> +maxScaleIncrease:

Nit - perhaps a more specific name, such as maxTextAutosizingScaleIncrease? At first glance, `maxScaleIncrease` sounds a bit like a viewporty thing.
Comment 3 Radar WebKit Bug Importer 2018-02-19 08:07:41 PST 
<rdar://problem/37671259>
Comment 4 Tim Horton 2018-02-19 10:04:11 PST 
(In reply to Wenson Hsieh from comment #2)
> Comment on attachment 334137 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=334137&action=review
> 
> > Source/WebCore/page/Settings.yaml:724
> > +maxScaleIncrease:
> 
> Nit - perhaps a more specific name, such as maxTextAutosizingScaleIncrease?
> At first glance, `maxScaleIncrease` sounds a bit like a viewporty thing.

Yeah, that's a good point.
Comment 5 Tim Horton 2018-02-19 10:10:10 PST 
Created attachment 334163 [details]
Patch
Comment 6 WebKit Commit Bot 2018-02-19 10:47:36 PST 
Comment on attachment 334163 [details]
Patch

Clearing flags on attachment: 334163

Committed r228697: <https://trac.webkit.org/changeset/228697>
Comment 7 WebKit Commit Bot 2018-02-19 10:47:37 PST 
All reviewed patches have been landed.  Closing bug.