Bug 182854 - Disable release assertions in updateStyleIfNeeded and updateLayout
Summary: Disable release assertions in updateStyleIfNeeded and updateLayout
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-15 17:35 PST by Ryosuke Niwa
Modified: 2018-02-15 17:54 PST (History)
9 users (show)

See Also:

Attachments
Disable release asserts (2.64 KB, patch)
2018-02-15 17:42 PST, Ryosuke Niwa 		simon.fraser: review+
Details | Formatted Diff | Diff
Fixed release builds (3.04 KB, patch)
2018-02-15 17:52 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-02-15 17:35:23 PST 
We need to disable release assertions in updateStyleIfNeeded and updateLayout.
Comment 1 Ryosuke Niwa 2018-02-15 17:39:08 PST 
<rdar://problem/37590759>
Comment 2 Ryosuke Niwa 2018-02-15 17:42:39 PST 
Created attachment 333976 [details]
Disable release asserts
Comment 3 Build Bot 2018-02-15 17:45:06 PST 
Attachment 333976 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/Document.cpp:1969:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
ERROR: Source/WebCore/dom/Document.cpp:1985:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
ERROR: Source/WebCore/page/LayoutContext.cpp:125:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
Total errors found: 3 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Ryosuke Niwa 2018-02-15 17:52:00 PST 
Created attachment 333977 [details]
Fixed release builds
Comment 5 Build Bot 2018-02-15 17:54:24 PST 
Attachment 333977 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/Document.cpp:1971:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
ERROR: Source/WebCore/dom/Document.cpp:1987:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
ERROR: Source/WebCore/page/LayoutContext.cpp:125:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
Total errors found: 3 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.