RESOLVED FIXED 182791
[Modern Media Controls] Don't use arrays as values for localisable strings 
https://bugs.webkit.org/show_bug.cgi?id=182791
Summary [Modern Media Controls] Don't use arrays as values for localisable strings
Antoine Quint
Reported 2018-02-14 05:34:32 PST
We have two localizable strings that are defined as arrays rather than plain strings in order to allow localization of the skip amount. These should use regular strings and the skip amount should be replaced in code instead.
Attachments
Patch (7.15 KB, patch)
2018-02-14 05:39 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-sierra (2.19 MB, application/zip)
2018-02-14 06:38 PST, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (2.59 MB, application/zip)
2018-02-14 06:43 PST, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews115 for mac-sierra (2.91 MB, application/zip)
2018-02-14 07:08 PST, EWS Watchlist 		no flags
Details
Patch (9.97 KB, patch)
2018-02-14 08:01 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2018-02-14 05:34:45 PST
<rdar://problem/36007262>
Antoine Quint
Comment 2 2018-02-14 05:39:28 PST
Created attachment 333789 [details] Patch
EWS Watchlist
Comment 3 2018-02-14 06:38:44 PST
Comment on attachment 333789 [details] Patch Attachment 333789 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6499861 New failing tests: media/modern-media-controls/localized-strings/replaced-string.html
EWS Watchlist
Comment 4 2018-02-14 06:38:46 PST
Created attachment 333795 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 5 2018-02-14 06:43:24 PST
Comment on attachment 333789 [details] Patch Attachment 333789 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6499870 New failing tests: media/modern-media-controls/localized-strings/replaced-string.html
EWS Watchlist
Comment 6 2018-02-14 06:43:26 PST
Created attachment 333796 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 7 2018-02-14 07:08:29 PST
Comment on attachment 333789 [details] Patch Attachment 333789 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6499951 New failing tests: media/modern-media-controls/localized-strings/replaced-string.html
EWS Watchlist
Comment 8 2018-02-14 07:08:30 PST
Created attachment 333797 [details] Archive of layout-test-results from ews115 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6
Antoine Quint
Comment 9 2018-02-14 08:01:23 PST
Created attachment 333801 [details] Patch
WebKit Commit Bot
Comment 10 2018-02-14 10:46:16 PST
Comment on attachment 333801 [details] Patch Clearing flags on attachment: 333801 Committed r228471: <https://trac.webkit.org/changeset/228471>
WebKit Commit Bot
Comment 11 2018-02-14 10:46:18 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.