Bug 182791 - [Modern Media Controls] Don't use arrays as values for localisable strings
Summary: [Modern Media Controls] Don't use arrays as values for localisable strings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-14 05:34 PST by Antoine Quint
Modified: 2018-02-14 10:46 PST (History)
5 users (show)

See Also:

Attachments
Patch (7.15 KB, patch)
2018-02-14 05:39 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-sierra (2.19 MB, application/zip)
2018-02-14 06:38 PST, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (2.59 MB, application/zip)
2018-02-14 06:43 PST, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews115 for mac-sierra (2.91 MB, application/zip)
2018-02-14 07:08 PST, EWS Watchlist 		no flags Details
Patch (9.97 KB, patch)
2018-02-14 08:01 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2018-02-14 05:34:32 PST 
We have two localizable strings that are defined as arrays rather than plain strings in order to allow localization of the skip amount. These should use regular strings and the skip amount should be replaced in code instead.
Comment 1 Antoine Quint 2018-02-14 05:34:45 PST 
<rdar://problem/36007262>
Comment 2 Antoine Quint 2018-02-14 05:39:28 PST 
Created attachment 333789 [details]
Patch
Comment 3 EWS Watchlist 2018-02-14 06:38:44 PST 
Comment on attachment 333789 [details]
Patch

Attachment 333789 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6499861

New failing tests:
media/modern-media-controls/localized-strings/replaced-string.html
Comment 4 EWS Watchlist 2018-02-14 06:38:46 PST 
Created attachment 333795 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 5 EWS Watchlist 2018-02-14 06:43:24 PST 
Comment on attachment 333789 [details]
Patch

Attachment 333789 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6499870

New failing tests:
media/modern-media-controls/localized-strings/replaced-string.html
Comment 6 EWS Watchlist 2018-02-14 06:43:26 PST 
Created attachment 333796 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 7 EWS Watchlist 2018-02-14 07:08:29 PST 
Comment on attachment 333789 [details]
Patch

Attachment 333789 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/6499951

New failing tests:
media/modern-media-controls/localized-strings/replaced-string.html
Comment 8 EWS Watchlist 2018-02-14 07:08:30 PST 
Created attachment 333797 [details]
Archive of layout-test-results from ews115 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 9 Antoine Quint 2018-02-14 08:01:23 PST 
Created attachment 333801 [details]
Patch
Comment 10 WebKit Commit Bot 2018-02-14 10:46:16 PST 
Comment on attachment 333801 [details]
Patch

Clearing flags on attachment: 333801

Committed r228471: <https://trac.webkit.org/changeset/228471>
Comment 11 WebKit Commit Bot 2018-02-14 10:46:18 PST 
All reviewed patches have been landed.  Closing bug.