Bug 182602 - Move compiled selectors to StyleRule
Summary: Move compiled selectors to StyleRule
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2018-02-08 05:06 PST by Antti Koivisto
Modified: 2018-02-09 01:12 PST (History)
3 users (show)

See Also:

patch (23.65 KB, patch)
2018-02-08 05:58 PST, Antti Koivisto
zalan: review+
Details | Formatted Diff | Diff
patch (23.97 KB, patch)
2018-02-09 00:25 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2018-02-08 05:06:54 PST
Currently they are owned by RuleData. Several RuleData objects can refer to the same StyleRule, requiring recompilation. Compiled selectors are context-independent so they can be shared between all clients.
Comment 1 Antti Koivisto 2018-02-08 05:58:13 PST
Created attachment 333373 [details]
Comment 2 Antti Koivisto 2018-02-09 00:25:34 PST
Created attachment 333455 [details]
Comment 3 WebKit Commit Bot 2018-02-09 01:11:10 PST
Comment on attachment 333455 [details]

Clearing flags on attachment: 333455

Committed r228313: <https://trac.webkit.org/changeset/228313>
Comment 4 WebKit Commit Bot 2018-02-09 01:11:11 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-02-09 01:12:20 PST