Bug 182529 - [Modern Media Controls] Test at media/modern-media-controls/placard/placard-ltr.html fails on second run
Summary: [Modern Media Controls] Test at media/modern-media-controls/placard/placard-l...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-06 03:00 PST by Antoine Quint
Modified: 2020-12-10 15:08 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.83 KB, patch)
2018-02-06 03:01 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2018-02-06 03:00:19 PST 
[Modern Media Controls] Test at media/modern-media-controls/placard/placard-ltr.html fails on second run
Comment 1 Antoine Quint 2018-02-06 03:01:02 PST 
Created attachment 333166 [details]
Patch
Comment 2 Alexey Proskuryakov 2018-02-06 06:45:03 PST 
Comment on attachment 333166 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333166&action=review

> LayoutTests/ChangeLog:8
> +        We need to reset the user interface direction after changing it before exiting the test or else it will

Should WKTR and DRT do that? That would be more robust than depending on tests to clean up.
Comment 3 Antoine Quint 2018-02-06 11:35:23 PST 
(In reply to Alexey Proskuryakov from comment #2)
> Comment on attachment 333166 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=333166&action=review
> 
> > LayoutTests/ChangeLog:8
> > +        We need to reset the user interface direction after changing it before exiting the test or else it will
> 
> Should WKTR and DRT do that? That would be more robust than depending on
> tests to clean up.

That would be better, let me try to fix this in the test runners.