On trunk, we currently have a release assert that asserts that scripts are allowed when calling FrameLoader::stopAllLoaders. This is correct since stopAllLoaders might dispatch events. We should continue to have the release assert in trunk, because we should catch when this happens. However, there still might be cases where the assert fails, but the backtrace will turn out to be one where scripting could be allowed. The release assert in trunk will help us catch these cases. On the branch, however, we should avoid crashing in these cases, and replace the release assert with a debug assert. If approved, this patch should only land on a branch, not on trunk.
Created attachment 333085 [details] Patch
Attachment 333085 [details] did not pass style-queue: ERROR: Source/WebCore/loader/FrameLoader.cpp:1681: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.