Bug 182439 - Allow apps built before SDK with file URL XHR header restriction to work
Summary: Allow apps built before SDK with file URL XHR header restriction to work
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-02 09:43 PST by Daniel Bates
Modified: 2018-02-05 09:53 PST (History)
7 users (show)

See Also:


Attachments
Patch (7.60 KB, patch)
2018-02-02 09:50 PST, Daniel Bates
rniwa: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2018-02-02 09:43:58 PST
Allow apps built before SDK with file URL XHR header restriction to work. In <https://trac.webkit.org/changeset/222795> (bug #177824) only Dashboard widgets were exempt from XHR header restrictions. As it turns out this broke Cardiogram and we subsequently exempted Cardiogram in the patch for bug #181693. Nike is another app that is affect by bug #177824. Let's exempt all Mac and iOS apps that were built with an SDK before the patch for bug bug #177824 to allow developers time to update their app(s).
Comment 1 Daniel Bates 2018-02-02 09:49:11 PST
<rdar://problem/36533447>
Comment 2 Daniel Bates 2018-02-02 09:50:00 PST
Created attachment 332977 [details]
Patch
Comment 3 Ryosuke Niwa 2018-02-02 15:05:59 PST
Comment on attachment 332977 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332977&action=review

> Source/WTF/wtf/spi/darwin/dyldSPI.h:46
> +#ifndef DYLD_MACOSX_VERSION_10_13_4
> +#define DYLD_MACOSX_VERSION_10_13_4 0x000A0D04
> +#endif

I thought macOS only updated dyld version for a major release?
Comment 4 Ryosuke Niwa 2018-02-02 15:06:44 PST
Comment on attachment 332977 [details]
Patch

r=me assuming that the check actually works. I think Wenson and I concluded that it didn't for clipboard work though...
Comment 5 Ryosuke Niwa 2018-02-02 15:08:14 PST
Comment on attachment 332977 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332977&action=review

> Source/WebCore/ChangeLog:11
> +        (WebCore::IOSApplication::isCardiogram): Deleted.

You might wanna clarify that we already allow this legacy behavior on all iOS apps
linked SDK before iOS 11.3 and refer to the revision in which you made that change.
Comment 6 Wenson Hsieh 2018-02-02 16:41:40 PST
(In reply to Ryosuke Niwa from comment #4)
> Comment on attachment 332977 [details]
> Patch
> 
> r=me assuming that the check actually works. I think Wenson and I concluded
> that it didn't for clipboard work though...

(FYI: <rdar://problem/35484255> is what I had in mind).
Comment 7 Daniel Bates 2018-02-05 09:53:35 PST
Brent Fulgham and I talked about this bug today (02/05/2018). We feel it is sufficient to just exempt the Nike app (See bug #182491) for now. If we discover more fallout from <https://trac.webkit.org/changeset/222795> (bug #177824) then we can consider this patch again.
Comment 8 Radar WebKit Bug Importer 2018-02-05 09:53:57 PST
<rdar://problem/37240400>