The following layout test is a flaky timeout on macOS WK2 http/tests/resourceLoadStatistics/non-prevalent-resource-with-user-interaction.html Probable cause: The timeouts go back further than the flakiness dashboard shows. Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2FresourceLoadStatistics%2Fnon-prevalent-resource-with-user-interaction.html https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r227933%20(2656)/results.html https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/builds/2656 Diff: --- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/tests/resourceLoadStatistics/non-prevalent-resource-with-user-interaction-expected.txt +++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/tests/resourceLoadStatistics/non-prevalent-resource-with-user-interaction-actual.txt @@ -1,2 +1,5 @@ -PASS Cookie not deleted. +#PID UNRESPONSIVE - com.apple.WebKit.WebContent.Development (pid 62073) +FAIL: Timed out waiting for notifyDone to be called +#EOF +#EOF
<rdar://problem/37094805>
Skipped for now in: https://trac.webkit.org/changeset/227986/webkit
Skipping this test seems to have caused http/tests/resourceLoadStatistics/non-prevalent-resource-without-user-interaction.html to time out. https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2FresourceLoadStatistics%2Fnon-prevalent-resource-without-user-interaction.html
Perhaps running http/tests/resourceLoadStatistics tests with --repeat-each will help determine which test is the real culprit. Matt, would you be willing to try that out?
Created attachment 333330 [details] Patch
Just waiting for EWS feedback on this one before I land.
Comment on attachment 333330 [details] Patch Failing iOS-sim tests are unrelated.
Comment on attachment 333330 [details] Patch Clearing flags on attachment: 333330 Committed r228252: <https://trac.webkit.org/changeset/228252>
All reviewed patches have been landed. Closing bug.