Bug 182346 – [GTK][WPE] Add dependencies watching lists for WKGTK+ and WPE

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andres Gomez Garcia]

[GTK][WPE] Add dependencies watching lists for WKGTK+ and WPE

[Andres Gomez Garcia]

Created attachment 332792 [details]
Patch

[Andres Gomez Garcia]

Notice that I'm adding Loren in the watchlist but he is not a contributor and the check-webkit-style script complains about it.

I'm not sure this is a problem, though.

Additionally, I think this patch is a good idea to follow-up with dependencies changes in the EWS but maybe Adrian doesn't want the noise or you think that, in general, this is not a good idea.

Carlos Lopez, I've not added you but maybe you would like to ...

Anyway, comments are welcome.

[EWS Watchlist]

Attachment 332792 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/config/watchlist:0:  The email alias [e-mail] which is in the watchlist is not listed as a contributor in contributors.json  [watchlist/general] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Adrian Perez]

(In reply to Andres Gomez Garcia from comment #2)
> Notice that I'm adding Loren in the watchlist but he is not a contributor
> and the check-webkit-style script complains about it.
> 
> I'm not sure this is a problem, though.
> 
> Additionally, I think this patch is a good idea to follow-up with
> dependencies changes in the EWS but maybe Adrian doesn't want the noise or
> you think that, in general, this is not a good idea.

Personally, I am fine being added here in the watchlist, thanks for
coming up with the idea of adding some more of us here :-)

[Michael Catanzaro]

Comment on attachment 332792 [details]
Patch

This looks like a good idea to me, but best add Loren as a contributor first. You can add people to contributors.json without marking them as a committer or reviewer. I've done this before because it's needed for CC autocompletion on Bugzilla.

[Lorenzo Tilve]

(In reply to Adrian Perez from comment #4)
> 
> Personally, I am fine being added here in the watchlist, thanks for
> coming up with the idea of adding some more of us here :-)

Sure, I am also fine with being added too. Thanks :-)

[Carlos Alberto Lopez Perez]

(In reply to Andres Gomez Garcia from comment #2)
> Carlos Lopez, I've not added you but maybe you would like to ...
> 

Yes, please add me to both. Thanks

[Andres Gomez Garcia]

Created attachment 333161 [details]
Patch

[EWS Watchlist]

Attachment 333161 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0:  contributors.json should not be modified through the commit queue  [json/syntax] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andres Gomez Garcia]

Created attachment 333172 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 333172 [details]
Patch

Clearing flags on attachment: 333172

Committed r228172: <https://trac.webkit.org/changeset/228172>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/37275187>