Bug 182295 - W3C: WebAutomationSession::navigateBrowsingContext should implement "navigate to" command, steps 5–8
Summary: W3C: WebAutomationSession::navigateBrowsingContext should implement "navigate...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-30 09:17 PST by Brian Burg
Modified: 2018-01-30 09:29 PST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2018-01-30 09:17:51 PST
In both safaridriver and webkit's driver, none of the checks in steps 5-8 (including "post-navigation checks") are being done at all. This needs to happen in the WebKit side since it depends on examining the document loader / main resource response.
Comment 1 Brian Burg 2018-01-30 09:21:10 PST
Forgot the link:

https://w3c.github.io/webdriver/webdriver-spec.html#navigate-to

Practically speaking, we should be not running the page load timeout if this appears to be a same-document navigation (i.e., to a fragment). We also need to adjust the response if the navigation failed for some reason (handled by the "post-navigation checks" algorithm).

This command already does most steps of "wait for navigation to complete", though I haven't audited the code against the spec to see if we are missing any steps. It's likely that W3C test coverage is not good for the finer points of the algorithm.
Comment 2 Radar WebKit Bug Importer 2018-01-30 09:29:47 PST
<rdar://problem/37031629>