WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
182294
WebDriver: add domains to server config in w3c tests
https://bugs.webkit.org/show_bug.cgi?id=182294
Summary
WebDriver: add domains to server config in w3c tests
Carlos Garcia Campos
Reported
2018-01-30 08:22:51 PST
Several cookie tests expect server_config to have a domains key. ___________________________________________________________________________________ test_duplicated_cookie ___________________________________________________________________________________ session = <webdriver.client.Session object at 0x7f20aefa2550>, url = <function url at 0x7f20aef3b668>, server_config = {'host': 'localhost', 'ports': {'http': ['8802']}} def test_duplicated_cookie(session, url, server_config): session.url = url("/common/blank.html") clear_all_cookies(session) create_cookie_request = { "cookie": { "name": "hello", "value": "world",
> "domain": server_config["domains"][""],
E KeyError: 'domains' server_config = {'host': 'localhost', 'ports': {'http': ['8802']}} session = <webdriver.client.Session object at 0x7f20aefa2550> url = <function url at 0x7f20aef3b668> WebDriverTests/imported/w3c/webdriver/tests/cookies/get_named_cookie.py:72: KeyError
Attachments
Patch
(1.87 KB, patch)
2018-01-30 08:28 PST
,
Carlos Garcia Campos
clopez
: review+
ews-watchlist
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from ews206 for win-future
(11.50 MB, application/zip)
2018-01-30 13:26 PST
,
EWS Watchlist
no flags
Details
View All
Add attachment
proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1
2018-01-30 08:28:48 PST
Created
attachment 332657
[details]
Patch
EWS Watchlist
Comment 2
2018-01-30 13:25:59 PST
Comment on
attachment 332657
[details]
Patch
Attachment 332657
[details]
did not pass win-ews (win): Output:
http://webkit-queues.webkit.org/results/6264253
New failing tests: http/tests/preload/onerror_event.html
EWS Watchlist
Comment 3
2018-01-30 13:26:10 PST
Created
attachment 332693
[details]
Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Carlos Garcia Campos
Comment 4
2018-01-31 01:08:45 PST
Committed
r227881
: <
https://trac.webkit.org/changeset/227881
>
Radar WebKit Bug Importer
Comment 5
2018-01-31 01:10:13 PST
<
rdar://problem/37061215
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug