Bug 182000 - [iOS] [WK2] Introduce new views and view controllers to support extra-zoomed text form controls
Summary: [iOS] [WK2] Introduce new views and view controllers to support extra-zoomed ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-23 11:57 PST by Wenson Hsieh
Modified: 2018-01-25 20:17 PST (History)
7 users (show)

See Also:

Attachments
Patch (30.92 KB, patch)
2018-01-23 12:29 PST, Wenson Hsieh 		thorton: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-01-23 11:57:58 PST 
<rdar://problem/35143035>
Comment 1 Wenson Hsieh 2018-01-23 12:29:51 PST 
Created attachment 332063 [details]
Patch
Comment 2 WebKit Commit Bot 2018-01-25 18:50:27 PST 
Comment on attachment 332063 [details]
Patch

Rejecting attachment 332063 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 332063, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
file Source/WebKit/WebKit.xcodeproj/project.pbxproj
Hunk #1 FAILED at 722.
Hunk #2 FAILED at 3058.
Hunk #3 FAILED at 8295.
Hunk #4 FAILED at 8310.
Hunk #5 FAILED at 9331.
Hunk #6 FAILED at 9493.
Hunk #7 FAILED at 10965.
Hunk #8 FAILED at 11072.
8 out of 8 hunks FAILED -- saving rejects to file Source/WebKit/WebKit.xcodeproj/project.pbxproj.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Tim Horton']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/6216936
Comment 3 Wenson Hsieh 2018-01-25 20:17:39 PST 
Commit-queue landed this in <https://trac.webkit.org/r227645>, but at the same time, it also marked this as cq- and left a comment saying that the patch failed to apply. I'm not sure how this happened...

+ aakash and lforschler