Bug 181997 - Rollout r219636
Summary: Rollout r219636
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robin Morisset
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-23 11:15 PST by Robin Morisset
Modified: 2018-01-23 12:50 PST (History)
7 users (show)

See Also:


Attachments
Patch (3.55 KB, patch)
2018-01-23 11:21 PST, Robin Morisset
no flags Details | Formatted Diff | Diff
Patch (3.56 KB, patch)
2018-01-23 11:41 PST, Robin Morisset
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Morisset 2018-01-23 11:15:25 PST
A bug was found in it and patching it is not trivial, so let's revert it in the meantime.
Comment 1 Robin Morisset 2018-01-23 11:21:15 PST
Created attachment 332044 [details]
Patch
Comment 2 Mark Lam 2018-01-23 11:24:37 PST
Comment on attachment 332044 [details]
Patch

Clear the review flag because rollouts not require a review.
Comment 3 Robin Morisset 2018-01-23 11:25:07 PST
<rdar://problem/35883022>
Comment 4 WebKit Commit Bot 2018-01-23 11:27:23 PST
Comment on attachment 332044 [details]
Patch

Rejecting attachment 332044 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 332044, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/JavaScriptCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/6184589
Comment 5 Robin Morisset 2018-01-23 11:41:19 PST
Created attachment 332048 [details]
Patch
Comment 6 WebKit Commit Bot 2018-01-23 12:49:30 PST
Comment on attachment 332048 [details]
Patch

Clearing flags on attachment: 332048

Committed r227435: <https://trac.webkit.org/changeset/227435>
Comment 7 WebKit Commit Bot 2018-01-23 12:49:31 PST
All reviewed patches have been landed.  Closing bug.