Bug 181992 - Web Inspector: Window resizing is broken after detaching to separate window
Summary: Web Inspector: Window resizing is broken after detaching to separate window
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-23 10:36 PST by Joseph Pecoraro
Modified: 2018-01-23 12:08 PST (History)
6 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.55 KB, patch)
2018-01-23 10:39 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2018-01-23 10:36:57 PST 
Window resizing is broken after detaching to separate window

Steps to Reproduce:
1. Inspect <http://webkit.org> starting with a detached window
2. Attach to bottom
3. Detach
4. Attempt to resize the window
  => Broken UI

Notes:
• Resizing works at (1) but is broken at (4)
• Attaching the window (2) changes the WKWebView's autoresizingMask
• Restoring the autoresizingMask to the initial value behaves as expected
Comment 1 Joseph Pecoraro 2018-01-23 10:37:10 PST 
<rdar://problem/36714840>
Comment 2 Joseph Pecoraro 2018-01-23 10:39:42 PST 
Created attachment 332037 [details]
[PATCH] Proposed Fix

I suppose an alternative fix would be to put this line in WebInspectorProxyMac::platformCreateFrontendWindow when the view gets added to the window, but I thought this location made more sense, since it balances the changes made in platformAttach with an equivalent property change in platformDetach.
Comment 3 BJ Burg 2018-01-23 11:45:04 PST 
Comment on attachment 332037 [details]
[PATCH] Proposed Fix

r=me
Comment 4 WebKit Commit Bot 2018-01-23 12:08:40 PST 
Comment on attachment 332037 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 332037

Committed r227429: <https://trac.webkit.org/changeset/227429>
Comment 5 WebKit Commit Bot 2018-01-23 12:08:41 PST 
All reviewed patches have been landed.  Closing bug.