Bug 181956 – REGRESSION (r227348): ASSERT_NOT_REACHED in WebKit::ServiceWorkerClientFetch::didFinish()

• Status: RESOLVED
• Resolution: FIXED
• Component: Service Workers

[Ryan Haddad]

The following assertion failure was seen on iOS Simulator Debug WK2 with imported/w3c/web-platform-tests/service-workers/service-worker/navigation-redirect-body.https.html:

/Volumes/Data/slave/ios-simulator-11-debug/build/Source/WebCore/workers/service/server/SWServer.cpp(438) : void WebCore::SWServer::removeClientServiceWorkerRegistration(WebCore::SWServer::Connection &, ServiceWorkerRegistrationIdentifier)
SHOULD NEVER BE REACHED
/Volumes/Data/slave/ios-simulator-11-debug/build/Source/WebKit/WebProcess/Storage/ServiceWorkerClientFetch.cpp(165) : void WebKit::ServiceWorkerClientFetch::didFinish()
1   0x10f851f6d WTFCrash
2   0x1020f78fa WebKit::ServiceWorkerClientFetch::didFinish()
3   0x1020faf2e void IPC::callMemberFunctionImpl<WebKit::ServiceWorkerClientFetch, void (WebKit::ServiceWorkerClientFetch::*)(), std::__1::tuple<> >(WebKit::ServiceWorkerClientFetch*, void (WebKit::ServiceWorkerClientFetch::*)(), std::__1::tuple<>&&, std::__1::integer_sequence<unsigned long>)
4   0x1020faea0 void IPC::callMemberFunction<WebKit::ServiceWorkerClientFetch, void (WebKit::ServiceWorkerClientFetch::*)(), std::__1::tuple<>, std::__1::integer_sequence<unsigned long> >(std::__1::tuple<>&&, WebKit::ServiceWorkerClientFetch*, void (WebKit::ServiceWorkerClientFetch::*)())
5   0x1020f9a6d void IPC::handleMessage<Messages::ServiceWorkerClientFetch::DidFinish, WebKit::ServiceWorkerClientFetch, void (WebKit::ServiceWorkerClientFetch::*)()>(IPC::Decoder&, WebKit::ServiceWorkerClientFetch*, void (WebKit::ServiceWorkerClientFetch::*)())
6   0x1020f9346 WebKit::ServiceWorkerClientFetch::didReceiveMessage(IPC::Connection&, IPC::Decoder&)
7   0x102816fda WebKit::WebServiceWorkerProvider::didReceiveServiceWorkerClientFetchMessage(IPC::Connection&, IPC::Decoder&)
8   0x1028cbbc0 WebKit::WebToStorageProcessConnection::didReceiveMessage(IPC::Connection&, IPC::Decoder&)
9   0x101d16b33 IPC::Connection::dispatchMessage(IPC::Decoder&)
10  0x101d0c758 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)
11  0x101d1713a IPC::Connection::dispatchOneMessage()
12  0x101d2ef5d IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_14::operator()()
13  0x101d2eeb9 WTF::Function<void ()>::CallableWrapper<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_14>::call()
14  0x10f86e22b WTF::Function<void ()>::operator()() const
15  0x10f8b19fd WTF::RunLoop::performWork()
16  0x10f8b21b4 WTF::RunLoop::performWork(void*)
17  0x10625c2b1 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__
18  0x1062fbd31 __CFRunLoopDoSource0
19  0x106240c19 __CFRunLoopDoSources0
20  0x1062401ff __CFRunLoopRun
21  0x10623fa89 CFRunLoopRunSpecific
22  0x1015d9e5e -[NSRunLoop(NSRunLoop) runMode:beforeDate:]
23  0x1015d9d39 -[NSRunLoop(NSRunLoop) run]
24  0x107d4f0d9 _xpc_objc_main
25  0x107d514cb xpc_main
26  0x10152dbfe main
27  0x1079fad81 start
28  0x1

https://build.webkit.org/results/Apple%20iOS%2011%20Simulator%20Debug%20WK2%20(Tests)/r227349%20(2246)/results.html

[Ryan Haddad]

Created attachment 331967 [details]
crash log

[Chris Dumez]

    case RedirectionStatus::Received:
        ASSERT_NOT_REACHED();

For Youenn.

[Ryan Haddad]

This appears to have regressed with https://trac.webkit.org/changeset/227348/webkit

[Radar WebKit Bug Importer]

<rdar://problem/36755492>

[youenn fablet]

Created attachment 332010 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 332010 [details]
Patch

Clearing flags on attachment: 332010

Committed r227419: <https://trac.webkit.org/changeset/227419>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.