Bug 181930 - [Cairo] Refactor PlatformContextCairo::drawSurfaceToContext() into a Cairo operation
Summary: [Cairo] Refactor PlatformContextCairo::drawSurfaceToContext() into a Cairo op...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-22 03:45 PST by Zan Dobersek
Modified: 2018-01-22 06:24 PST (History)
5 users (show)

See Also:

Attachments
Patch (18.90 KB, patch)
2018-01-22 03:50 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-sierra-wk2 (2.62 MB, application/zip)
2018-01-22 05:23 PST, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2018-01-22 03:45:27 PST 
[Cairo] Refactor PlatformContextCairo::drawSurfaceToContext() into a Cairo operation
Comment 1 Zan Dobersek 2018-01-22 03:50:13 PST 
Created attachment 331912 [details]
Patch
Comment 2 EWS Watchlist 2018-01-22 03:52:37 PST 
Attachment 331912 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/cairo/CairoOperations.cpp:834:  'patternSurface' is incorrectly named. It should be named 'protector' or 'protectedSurface'.  [readability/naming/protected] [4]
WARNING: This machine could support 4 simulators, but is only configured for 3.
WARNING: Please see <https://trac.webkit.org/wiki/IncreasingKernelLimits>.
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 EWS Watchlist 2018-01-22 05:23:03 PST 
Comment on attachment 331912 [details]
Patch

Attachment 331912 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6168184

New failing tests:
media/video-main-content-autoplay.html
Comment 4 EWS Watchlist 2018-01-22 05:23:04 PST 
Created attachment 331917 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 5 Zan Dobersek 2018-01-22 06:23:10 PST 
Comment on attachment 331912 [details]
Patch

Clearing flags on attachment: 331912

Committed r227292: <https://trac.webkit.org/changeset/227292>
Comment 6 Zan Dobersek 2018-01-22 06:23:14 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-01-22 06:24:33 PST 
<rdar://problem/36731574>