Bug 181922 - In WebKit2, make the MessagePortChannelRegistry live in the UI process
Summary: In WebKit2, make the MessagePortChannelRegistry live in the UI process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-21 22:12 PST by Brady Eidson
Modified: 2018-01-29 15:49 PST (History)
10 users (show)

See Also:


Attachments
Patch (61.72 KB, patch)
2018-01-21 23:25 PST, Brady Eidson
no flags Details | Formatted Diff | Diff
Patch (61.84 KB, patch)
2018-01-22 08:02 PST, Brady Eidson
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (2.63 MB, application/zip)
2018-01-22 09:10 PST, EWS Watchlist
no flags Details
Patch (65.38 KB, patch)
2018-01-22 09:21 PST, Brady Eidson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2018-01-21 22:12:33 PST
In WebKit2, make the MessagePortChannelRegistry live in the UI process

This is the final step towards https://bugs.webkit.org/show_bug.cgi?id=181178
Comment 1 Brady Eidson 2018-01-21 23:25:10 PST
Created attachment 331899 [details]
Patch
Comment 2 Brady Eidson 2018-01-22 08:02:25 PST
Created attachment 331926 [details]
Patch
Comment 3 EWS Watchlist 2018-01-22 09:10:07 PST
Comment on attachment 331926 [details]
Patch

Attachment 331926 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6169989

New failing tests:
media/video-main-content-autoplay.html
Comment 4 EWS Watchlist 2018-01-22 09:10:09 PST
Created attachment 331933 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 5 Brady Eidson 2018-01-22 09:19:53 PST
(In reply to Build Bot from comment #4)
> Created attachment 331933 [details]
> Archive of layout-test-results from ews106 for mac-sierra-wk2
> 
> The attached test failures were seen while running run-webkit-tests on the
> mac-wk2-ews.
> Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

(In reply to Build Bot from comment #3)
> Comment on attachment 331926 [details]
> Patch
> 
> Attachment 331926 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: http://webkit-queues.webkit.org/results/6169989
> 
> New failing tests:
> media/video-main-content-autoplay.html

This seems to have nothing to do with this patch.
Comment 6 Brady Eidson 2018-01-22 09:21:55 PST
Created attachment 331934 [details]
Patch
Comment 7 Brady Eidson 2018-01-22 09:29:27 PST
(In reply to Brady Eidson from comment #5)
> (In reply to Build Bot from comment #4)
> > Created attachment 331933 [details]
> > Archive of layout-test-results from ews106 for mac-sierra-wk2
> > 
> > The attached test failures were seen while running run-webkit-tests on the
> > mac-wk2-ews.
> > Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
> 
> (In reply to Build Bot from comment #3)
> > Comment on attachment 331926 [details]
> > Patch
> > 
> > Attachment 331926 [details] did not pass mac-wk2-ews (mac-wk2):
> > Output: http://webkit-queues.webkit.org/results/6169989
> > 
> > New failing tests:
> > media/video-main-content-autoplay.html
> 
> This seems to have nothing to do with this patch.

Indeed, it's crashing on the bots right now too.
https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r227291%20(2414)/results.html
Comment 8 WebKit Commit Bot 2018-01-22 10:35:29 PST
Comment on attachment 331934 [details]
Patch

Clearing flags on attachment: 331934

Committed r227340: <https://trac.webkit.org/changeset/227340>
Comment 9 WebKit Commit Bot 2018-01-22 10:35:30 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2018-01-22 10:37:54 PST
<rdar://problem/36739730>