Bug 181848 - [FTL] Drop NewRegexp for String.prototype.match with RegExp + global flag
Summary: [FTL] Drop NewRegexp for String.prototype.match with RegExp + global flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-19 05:20 PST by Yusuke Suzuki
Modified: 2018-03-12 17:25 PDT (History)
9 users (show)

See Also:

Attachments
Patch (34.47 KB, patch)
2018-01-19 05:25 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.15 MB, application/zip)
2018-01-19 06:56 PST, EWS Watchlist 		no flags Details
Patch (33.20 KB, patch)
2018-01-19 17:19 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-01-19 05:20:57 PST 
[FTL] Drop NewRegexp for String.prototype.match with RegExp + global flag
Comment 1 Yusuke Suzuki 2018-01-19 05:25:26 PST 
Created attachment 331722 [details]
Patch
Comment 2 EWS Watchlist 2018-01-19 06:56:52 PST 
Comment on attachment 331722 [details]
Patch

Attachment 331722 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/6134383

New failing tests:
imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-cache.https.html
Comment 3 EWS Watchlist 2018-01-19 06:56:53 PST 
Created attachment 331725 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 4 EWS Watchlist 2018-01-19 08:11:17 PST 
Comment on attachment 331722 [details]
Patch

Attachment 331722 [details] did not pass jsc-ews (mac):
Output: http://webkit-queues.webkit.org/results/6135139

New failing tests:
stress/regexp-replace-proxy.js.ftl-eager-no-cjit
stress/regexp-match-proxy.js.ftl-eager-no-cjit
Comment 5 EWS Watchlist 2018-01-19 09:41:40 PST 
Comment on attachment 331722 [details]
Patch

Attachment 331722 [details] did not pass jsc-ews (mac):
Output: http://webkit-queues.webkit.org/results/6134780

New failing tests:
stress/regexp-replace-proxy.js.ftl-eager-no-cjit
stress/regexp-match-proxy.js.ftl-eager-no-cjit
Comment 6 Yusuke Suzuki 2018-01-19 17:19:08 PST 
Created attachment 331825 [details]
Patch
Comment 7 Yusuke Suzuki 2018-02-02 09:21:40 PST 
Ping?
Comment 8 Yusuke Suzuki 2018-02-09 05:27:59 PST 
Ping review?
Comment 9 Yusuke Suzuki 2018-03-10 22:54:44 PST 
Comment on attachment 331825 [details]
Patch

Thabk you!
Comment 10 WebKit Commit Bot 2018-03-10 23:20:34 PST 
Comment on attachment 331825 [details]
Patch

Clearing flags on attachment: 331825

Committed r229514: <https://trac.webkit.org/changeset/229514>
Comment 11 WebKit Commit Bot 2018-03-10 23:20:35 PST 
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2018-03-12 17:25:03 PDT 
<rdar://problem/38397883>