Bug 181753 - Layout Test http/wpt/service-workers/update-service-worker.https.html is flaky
Summary: Layout Test http/wpt/service-workers/update-service-worker.https.html is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-17 11:23 PST by Matt Lewis
Modified: 2018-03-15 12:22 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.50 KB, patch)
2018-03-15 11:44 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Lewis 2018-01-17 11:23:20 PST
The following layout test is flaky on High Sierra Release WK2 and El Capitan Release WK2 at the moment.

http/wpt/service-workers/update-service-worker.https.html

Probable cause:

https://trac.webkit.org/changeset/226906/webkit

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Fwpt%2Fservice-workers%2Fupdate-service-worker.https.html

https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r227068%20(2302)/results.html

Diff:

--- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/wpt/service-workers/update-service-worker.https-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/wpt/service-workers/update-service-worker.https-actual.txt
@@ -1,4 +1,5 @@
+
 
 PASS Setup worker 
-PASS Ensure all fetches are intercepted 
+FAIL Ensure all fetches are intercepted promise_test: Unhandled rejection with value: object "TypeError: Type error"
Comment 1 Matt Lewis 2018-01-17 11:25:41 PST
Correction:

This is the cause. It looks to have been flaky since being added in 
https://trac.webkit.org/changeset/226904/webkit
Comment 2 Radar WebKit Bug Importer 2018-01-17 18:41:50 PST
<rdar://problem/36605091>
Comment 3 Matt Lewis 2018-01-22 13:33:48 PST
Marked as flaky in:
https://trac.webkit.org/changeset/227354/webkit
Comment 4 youenn fablet 2018-03-15 11:43:34 PDT
This is no longer flaky on High Sierra Release. I will update the test expectation.
Comment 5 youenn fablet 2018-03-15 11:44:58 PDT
Created attachment 335871 [details]
Patch
Comment 6 WebKit Commit Bot 2018-03-15 12:22:02 PDT
Comment on attachment 335871 [details]
Patch

Clearing flags on attachment: 335871

Committed r229636: <https://trac.webkit.org/changeset/229636>
Comment 7 WebKit Commit Bot 2018-03-15 12:22:03 PDT
All reviewed patches have been landed.  Closing bug.