Bug 181753 – Layout Test http/wpt/service-workers/update-service-worker.https.html is flaky

• Status: RESOLVED
• Resolution: FIXED
• Component: Service Workers

[Matt Lewis]

The following layout test is flaky on High Sierra Release WK2 and El Capitan Release WK2 at the moment.

http/wpt/service-workers/update-service-worker.https.html

Probable cause:

https://trac.webkit.org/changeset/226906/webkit

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Fwpt%2Fservice-workers%2Fupdate-service-worker.https.html

https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r227068%20(2302)/results.html

Diff:

--- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/wpt/service-workers/update-service-worker.https-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/wpt/service-workers/update-service-worker.https-actual.txt
@@ -1,4 +1,5 @@
+
 
 PASS Setup worker 
-PASS Ensure all fetches are intercepted 
+FAIL Ensure all fetches are intercepted promise_test: Unhandled rejection with value: object "TypeError: Type error"

[Matt Lewis]

Correction:

This is the cause. It looks to have been flaky since being added in 
https://trac.webkit.org/changeset/226904/webkit

[Radar WebKit Bug Importer]

<rdar://problem/36605091>

[Matt Lewis]

Marked as flaky in:
https://trac.webkit.org/changeset/227354/webkit

[youenn fablet]

This is no longer flaky on High Sierra Release. I will update the test expectation.

[youenn fablet]

Created attachment 335871 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 335871 [details]
Patch

Clearing flags on attachment: 335871

Committed r229636: <https://trac.webkit.org/changeset/229636>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.